Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): fetch token balances after a tx is submitted #5448

Merged
merged 2 commits into from
May 21, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

Should help with https://valora-app.slack.com/archives/C04B61SJ6DS/p1716315055922759?thread_ts=1716314300.065339&cid=C04B61SJ6DS

Test plan

Unit tests

Related issues

  • N/A

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a36105f) to head (4abc30a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5448      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.01%     
==========================================
  Files         756      756              
  Lines       31233    31236       +3     
  Branches     5364     5364              
==========================================
  Hits        26967    26967              
- Misses       4033     4036       +3     
  Partials      233      233              
Files Coverage Δ
src/earn/saga.ts 94.93% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36105f...4abc30a. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 21, 2024
@satish-ravi satish-ravi added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 211c71d May 21, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/earn-refresh-tokens branch May 21, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants