Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): header shown as white when bottom sheet is open #5467

Merged
merged 4 commits into from
May 29, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 24, 2024

Description

When the bottom sheet was opened on setting the header was shown in white instead of the same gray opaque seen on the rest of the screen. This PR fixes that on Android and iOS.

Screenshots

iOS Before Android Before iOS After Android After

Test plan

  • Tested locally on iOS
  • Tested locally on Android

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (9adf90e) to head (71bedac).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5467      +/-   ##
==========================================
+ Coverage   86.37%   86.41%   +0.03%     
==========================================
  Files         757      761       +4     
  Lines       31300    31365      +65     
  Branches     5383     5390       +7     
==========================================
+ Hits        27035    27103      +68     
+ Misses       4034     4031       -3     
  Partials      231      231              
Files Coverage Δ
src/account/Settings.tsx 91.62% <100.00%> (+0.11%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adf90e...71bedac. Read the comment docs.

satish-ravi
satish-ravi previously approved these changes May 24, 2024
src/account/Settings.tsx Outdated Show resolved Hide resolved
@satish-ravi satish-ravi dismissed their stale review May 24, 2024 19:58

seems like CustomHeader is a better solution

src/account/Settings.tsx Outdated Show resolved Hide resolved
src/account/Settings.tsx Outdated Show resolved Hide resolved
@MuckT MuckT enabled auto-merge May 29, 2024 15:41
@MuckT MuckT added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 9810375 May 29, 2024
16 checks passed
@MuckT MuckT deleted the tomm/act-1153 branch May 29, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants