fix(max): respect local decimal separator when setting max #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5551 +/- ##
========================================
Coverage 86.45% 86.46%
========================================
Files 762 762
Lines 31458 31458
Branches 5129 5422 +293
========================================
+ Hits 27197 27200 +3
+ Misses 4219 4027 -192
- Partials 42 231 +189
... and 78 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
reviewed
Jun 14, 2024
satish-ravi
approved these changes
Jun 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MuckT
added a commit
that referenced
this pull request
Jun 14, 2024
### Description Discovered with `EarnEnterAmount.tsx`, but also present in `EnterAmount.tsx` when pressing max the local decimilar separator was not set correctly preventing users from being able to delete characters from the input amount. ### Test plan - [x] Tested locally on iOS - [x] Tested locally on Android - [x] Unit tests updated ### Related issues N/A ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered with
EarnEnterAmount.tsx, but also present inEnterAmount.tsxwhen pressing max the local decimilar separator was not set correctly preventing users from being able to delete characters from the input amount.Test plan
Related issues
N/A
Backwards compatibility
Yes
Network scalability
N/A