chore: move onboarding phone verification experiment to feature gate #5563
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
==========================================
- Coverage 86.46% 86.45% -0.01%
==========================================
Files 765 765
Lines 31506 31505 -1
Branches 5458 5458
==========================================
- Hits 27243 27239 -4
+ Misses 4220 4034 -186
- Partials 43 232 +189
... and 78 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/onboarding/steps.ts
Outdated
| const { skipVerification } = getExperimentParams( | ||
| ExperimentConfigs[StatsigExperiments.ONBOARDING_PHONE_VERIFICATION] | ||
| ) | ||
| const skipVerification = getFeatureGate(StatsigFeatureGates.SHOW_ONBOARDING_PHONE_VERIFICATION) |
There was a problem hiding this comment.
should this be const skipVerification = !getFeatureGate(StatsigFeatureGates.SHOW_ONBOARDING_PHONE_VERIFICATION)? It looks like the feature gate is a boolean saying to show verification but then this const is a boolean saying to skip it.
There was a problem hiding this comment.
Fixed in 780994e! Interestingly, the tests missed this, but it appears expected due to how they set up mock props.
|
It seems that these tests are failing because the feature gate isn't returning enabled yet: Statsig. |
Description
Moves the onboarding experiment from #5256 to a feature gate and sets it to default enabled.
Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A