feat: setup skip phone verification experiment #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
Celo (test) 1.82.0 (147)
|
| Item | Install Size Change |
|---|---|
| 📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
| 📝 background@3x.jpg | ⬆️ 368.6 kB |
| 📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
| 📝 background@2x.jpg | ⬆️ 176.1 kB |
| 📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5256 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 745 745
Lines 30420 30424 +4
Branches 5273 5273
=======================================
+ Hits 26104 26108 +4
Misses 4079 4079
Partials 237 237
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
silasbw
approved these changes
Apr 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Moves `skipVerification` previously stored in app state to a Statsig Experiment; it appears this was originally put into app state so that it could be a/b tested. Now we're just using a different hook, `getExperimentParams`, instead of a `useSelector`. ### Test plan - Tested locally on iOS using a Stable ID in Statsig. - E2E tests in CI. - Unit tests in CI. ### Related issues - Fixes ACT-1163 ### Backwards compatibility Yes ### Network scalability N/A
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
…5563) ### Description Moves the onboarding experiment from #5256 to a feature gate and sets it to default enabled. ### Test plan - [x] Tested locally on iOS - [x] Tested locally on Android - [x] Unit tests updated ### Related issues - Fixes ACT-1202 ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves
skipVerificationpreviously stored in app state to a Statsig Experiment; it appears this was originally put into app state so that it could be a/b tested. Now we're just using a different hook,getExperimentParams, instead of auseSelector.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A