-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup skip phone verification experiment #5256
Conversation
1 build increased size
Celo (test) 1.82.0 (147)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5256 +/- ##
=======================================
Coverage 85.81% 85.81%
=======================================
Files 745 745
Lines 30420 30424 +4
Branches 5273 5273
=======================================
+ Hits 26104 26108 +4
Misses 4079 4079
Partials 237 237
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
### Description Moves `skipVerification` previously stored in app state to a Statsig Experiment; it appears this was originally put into app state so that it could be a/b tested. Now we're just using a different hook, `getExperimentParams`, instead of a `useSelector`. ### Test plan - Tested locally on iOS using a Stable ID in Statsig. - E2E tests in CI. - Unit tests in CI. ### Related issues - Fixes ACT-1163 ### Backwards compatibility Yes ### Network scalability N/A
…5563) ### Description Moves the onboarding experiment from #5256 to a feature gate and sets it to default enabled. ### Test plan - [x] Tested locally on iOS - [x] Tested locally on Android - [x] Unit tests updated ### Related issues - Fixes ACT-1202 ### Backwards compatibility Yes ### Network scalability N/A
Description
Moves
skipVerification
previously stored in app state to a Statsig Experiment; it appears this was originally put into app state so that it could be a/b tested. Now we're just using a different hook,getExperimentParams
, instead of auseSelector
.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A