Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(points): remove wrong and redundant image style property #5621

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

bakoushin
Copy link
Contributor

Description

Remove the imageResizeMode style property:

  • it is wrong, it should be resizeMode
  • the value cover is the default one, so this property is not needed at all

While not causing any harm to the users, it yields annoying RN error in dev mode:

image

Test plan

Tested manually

Related issues

Backwards compatibility

Y

Network scalability

NA

@bakoushin bakoushin enabled auto-merge July 5, 2024 14:33
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.49%. Comparing base (3d00470) to head (92540bd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #5621    +/-   ##
========================================
  Coverage   86.49%   86.49%            
========================================
  Files         772      772            
  Lines       31671    31671            
  Branches     5464     5466     +2     
========================================
  Hits        27393    27393            
- Misses       4044     4233   +189     
+ Partials      234       45   -189     
Files Coverage Δ
src/points/PointsDiscoverCard.tsx 100.00% <ø> (ø)

... and 79 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d00470...92540bd. Read the comment docs.

@bakoushin bakoushin added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit e5e2b3f Jul 5, 2024
16 checks passed
@bakoushin bakoushin deleted the alex/fix-points-dicover-card-styling-mistake branch July 5, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants