Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add goerli service #128

Merged
merged 6 commits into from
Mar 8, 2023
Merged

feat: add goerli service #128

merged 6 commits into from
Mar 8, 2023

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Feb 20, 2023

This PR adds a goerli service for the keep3r_bot.

@@ -0,0 +1,110 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is incompatible with normal framework loading mechanism as it's not in a build subfolder. Please fix so we can use these in the framework as well / stay consistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible for now, the ipfs connection cannot handle subdirs. Theres an issue for it on open-autonomy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok... Let's open an issue for this too then!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidMinarsch DavidMinarsch merged commit fa52fd0 into main Mar 8, 2023
@DavidMinarsch DavidMinarsch deleted the feat/keep3r-goerli branch March 8, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants