Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP redirects are broken #94

Closed
stevegraham opened this issue Aug 9, 2016 · 5 comments
Closed

HTTP redirects are broken #94

stevegraham opened this issue Aug 9, 2016 · 5 comments

Comments

@stevegraham
Copy link

:follow_redirects will not be picked up from process_options/1 or the default option from the application env.

Also the semantics of HTTP redirects are not followed, e.g. 303 should be a GET redirect, HTTPotion uses the same HTTP method.

@valpackett
Copy link
Owner

Please make a pull request that changes options[:follow_redirects] to args[:follow_redirects] and adds the missing semantics :)

@stevegraham
Copy link
Author

I don't use this library anymore. It's up to you if you want to fix the issue or leave it as is.

@valpackett
Copy link
Owner

The first part has been fixed in #101.

@arturictus
Copy link

Hi, how is this going?
do you need any help this this Issue?
can you guide me to fix it?

@valpackett
Copy link
Owner

@arturictus you can add the 303 semantics to the if response_ok(response) && is_redirect(response) && args[:follow_redirects] block :)

also look into making redirects work with async

ctreatma added a commit to ctreatma/httpotion that referenced this issue Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants