Fix #100: Follow redirects when extended #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API clients that are built by extending `HTTPotion.Base` can use the `process_options` hook to ensure that all redirects will be followed automatically. A typo in that module caused `follow_redirects` to be ignored. This adds a test to specifically cover the behavior of an API client using `process_options` to inject a `true` value for `follow_redirects`, and fixes the typo.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API clients that are built by extending
HTTPotion.Basecan use the
process_optionshook to ensure that allredirects will be followed automatically. A typo in that
module caused
follow_redirectsto be ignored.This adds a test to specifically cover the behavior of
an API client using
process_optionsto inject atruevalue for
follow_redirects, and fixes the typo.