Migrate to Libsoup 3 #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteymix
commented
Apr 12, 2022
| // var auth_data = Soup.header_parse_param_list (auth.substring (7)); | ||
| // req.uri.set_user (auth_data["username"]); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Two things here: uri is immutable, so this is not a suitable approach and str_case_equal is not visible despite passing --vapi with the internal libvsgi Vala symbols.
arteymix
commented
Apr 12, 2022
| } | ||
| if (_uri == null) { | ||
| // TODO | ||
| _uri = Uri.build (UriFlags.ENCODED_PATH, _uri_scheme, _uri_userinfo, _uri_host, _uri_port, _uri_path_encoded, _uri_query, null); |
There was a problem hiding this comment.
This will need a little bit more testing for various scenarios where the URI is set explicitly, or via CGI environment.
arteymix
commented
Apr 12, 2022
|
|
||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-22.04] |
There was a problem hiding this comment.
This runtime is not available yet on GitHub Actions.
arteymix
commented
Apr 12, 2022
| get { return this.message.status_code; } | ||
| set { this.message.status_code = value; } | ||
| get { return this.message.get_status (); } | ||
| set { this.message.set_status (value, null); } |
There was a problem hiding this comment.
Reuse the existing status message here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.