fix(cli): avoid scanning unnecessary directories on windows (n8n-io#4082

) fixes n8n-io#4007 Ticket: N8N-4603
valya · Sep 12, 2022 · afdf974 · afdf974
1 parent b28618f
commit afdf974
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/packages/cli/commands/import/credentials.ts b/packages/cli/commands/import/credentials.ts
@@ -95,7 +95,7 @@ export class ImportCredentialsCommand extends Command {
 
 				inputPath = inputPath.replace(/\/$/g, '');
 
-				const files = await glob(`${inputPath}/*.json`);
+				const files = await glob('*.json', { cwd: inputPath });
 
 				totalImported = files.length;
 

diff --git a/packages/cli/commands/import/workflow.ts b/packages/cli/commands/import/workflow.ts
@@ -117,7 +117,7 @@ export class ImportWorkflowsCommand extends Command {
 
 				inputPath = inputPath.replace(/\/$/g, '');
 
-				const files = await glob(`${inputPath}/*.json`);
+				const files = await glob('*.json', { cwd: inputPath });
 
 				totalImported = files.length;
 

diff --git a/packages/cli/src/LoadNodesAndCredentials.ts b/packages/cli/src/LoadNodesAndCredentials.ts
@@ -493,7 +493,9 @@ class LoadNodesAndCredentialsClass {
 	 * @returns {Promise<void>}
 	 */
 	async loadDataFromDirectory(setPackageName: string, directory: string): Promise<void> {
-		const files = await glob(path.join(directory, '**/*.@(node|credentials).js'));
+		const files = await glob('**/*.@(node|credentials).js', {
+			cwd: directory,
+		});
 
 		for (const filePath of files) {
 			const [fileName, type] = path.parse(filePath).name.split('.');

diff --git a/packages/nodes-base/nodes/ReadBinaryFiles/ReadBinaryFiles.node.ts b/packages/nodes-base/nodes/ReadBinaryFiles/ReadBinaryFiles.node.ts
@@ -1,7 +1,6 @@
 import { IExecuteFunctions } from 'n8n-core';
 import { INodeExecutionData, INodeType, INodeTypeDescription } from 'n8n-workflow';
 import glob from 'fast-glob';
-import path from 'path';
 
 import { readFile as fsReadFile } from 'fs/promises';