Can't set Content-Type on GET requests

[wendigo]

package main
import "github.com/valyala/fasthttp"
import "fmt"

func main() {
    header := fasthttp.RequestHeader{}

    header.SetRequestURI("http://localhost/test")
    header.Set("Accept", "application/json")
    header.Set("Arbitrary", "should-be-present")
    header.SetContentType("application/json")
    header.Set("Content-Type", "application/json")
    fmt.Printf("Header is: %s\n", string(header.String()))
}

Actual result:

Header is: GET http://localhost/test HTTP/1.1
User-Agent: fasthttp client
Accept: application/json
Arbitrary: should-be-present

According to the RFC2616 section 7.2.1 Content-Type should be set on methods containing entity but RFC does not prohibit to set it on other methods. Some APIs are using content-type to select API version on GET requests.

[abacaj]

Looks to me like it does set the content-type, but it does not print it with the String() method.

Validate this with fmt.Printf("Content-Type: %s\n", string(header.ContentType()))

[wendigo]

It's not sent over the wire. Double checked it.

[wendigo]

https://github.com/valyala/fasthttp/blob/master/header.go#L996 :)

[AlekSi]

So there is no way to set for PUT too?

[valyala]

Fixed

Thanks for the bug report :)

[valyala]

So there is no way to set for PUT too?

@AlekSi, PUT requests are now supported - see the commit 6a340b7 .

[wendigo]

👍

[AlekSi]

What about PATCH?

[valyala]

@AlekSi , done