Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheme check for not yet parsed requests #1203

Merged
merged 3 commits into from Jan 31, 2022
Merged

Fix scheme check for not yet parsed requests #1203

merged 3 commits into from Jan 31, 2022

Commits on Jan 28, 2022

  1. Fix scheme check for not yet parsed requests 

    At this point the request might not be parsed yet and set. In that case uri is empty and isHttps() returns always false. I don't expect this is intended?

Otherwise URL() must be called before actually passing the request to client.Do()
    @ArminBTVS
    ArminBTVS committed Jan 28, 2022
    Copy the full SHA
    28219af View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Add test

    @ArminBTVS
    ArminBTVS committed Jan 31, 2022
    Copy the full SHA
    956af3b View commit details
    Browse the repository at this point in the history

  2. Please linter

    @ArminBTVS
    ArminBTVS committed Jan 31, 2022
    Copy the full SHA
    92f77e8 View commit details
    Browse the repository at this point in the history