Request timeout settings for the same domain name are reused #1558
Conversation
fix client http SetReadDeadline/SetWriteDeadline Deadline is reused
byte0o
changed the title
There was a problem hiding this comment.
Great find!
It seems like you have to run gofmt to format the code properly. You're using spaces now but Go code is always indented with tabs.
The comments also aren't needed.
And it seems like some tests are failing now because they don't expect these functions to be called. Can you look into that?
|
Thanks! |
|
i have tested fiber with the master version and found this error
do i have to adjust anything else for us or is it a real error that has not been noticed ? |
|
@ReneWerner87 as you can see from the stacktrace the errors is in |
|
Ok I see, so we need to add these 2 methods to our test connection as well Thank you for the clarification |
"Request timeout settings for the same domain name are reused #1558" valyala/fasthttp#1558
* Bump github.com/valyala/fasthttp from 1.47.0 to 1.48.0 Bumps [github.com/valyala/fasthttp](https://github.com/valyala/fasthttp) from 1.47.0 to 1.48.0. - [Release notes](https://github.com/valyala/fasthttp/releases) - [Commits](valyala/fasthttp@v1.47.0...v1.48.0) --- updated-dependencies: - dependency-name: github.com/valyala/fasthttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * repair test setup for this change "Request timeout settings for the same domain name are reused #1558" valyala/fasthttp#1558 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: René Werner <rene@gofiber.io>
fix client http SetReadDeadline/SetWriteDeadline Deadline is reused