add DisableSpecialHeaders option #1573
Conversation
header.go
Outdated
| // If *RequestHeader.Read() is called, special headers will be parsed but not sent. | ||
| // e.g. *RequestHeader.Host() will return something, but the header will not be set when the request is sent. |
There was a problem hiding this comment.
| // If *RequestHeader.Read() is called, special headers will be parsed but not sent. | |
| // e.g. *RequestHeader.Host() will return something, but the header will not be set when the request is sent. | |
| // If RequestHeader.Read() is called, special headers will be parsed but not sent. | |
| // e.g. RequestHeader.Host() will return something, but the header will not be set when the request is sent. |
No need to specify the pointer receiver here.
There was a problem hiding this comment.
And wouldn't it be better to change methods like Host() to be
if h.disableSpecialHeader {
return h.Peek(strHost)
}
return h.hostso not to confuse people? The overhead of one if statement in these is worth it I think.
header_test.go
Outdated
| t.Fatalf("unexpected: %q. Expecting %q", h.Host(), "notfoobar") | ||
| } | ||
| // host is at the end of h.String() | ||
| if !strings.HasSuffix(h.String(), "host: notfoobar\r\n\r\n") { |
There was a problem hiding this comment.
Can you change this to a full h.String() == ".." instead of just a suffix check?
|
made your suggested changes, you can take another look |
|
Ahhh made some silly errors, should be good now |
header_test.go
Outdated
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| // Host and User-Agent are not parsed | ||
| if h.Host() != nil { |
There was a problem hiding this comment.
I don't understand why Host() should return nil here? Host: is present in the headers?
There was a problem hiding this comment.
ah this is because for Host and User-Agent they are saved as separate bytes, not present in the headers h.h. When we call Host() with special headers disabled it tries to read it from h.h. I guess technically parsing is currently unaffected, but I agree this behavior is confusing. I'll push another commit that makes sure to parse all special headers as regular headers
header_test.go
Outdated
| if h.Host() != nil { | ||
| t.Fatalf("unexpected: %q. Expecting nil", h.Host()) | ||
| } | ||
| if h.Host() != nil { |
There was a problem hiding this comment.
You're checking this twice.
|
Thanks! |
This is a PR is response to #1572
Thanks for your quick response, and for your work in maintaining this package overall. Here is a PR to entirely disable fasthttp setting special headers for you. This way the user has complete control over headers and the burden is on them to make sure things work correctly.
Feedback is welcome