test: remove //nolint:govet
comments
#1729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the tests for
noCopy
structs, eliminating the need for//nolint:govet
comments.govet
raises lint issues in tests on thereflect.DeepEqual(h1, h2)
line whereh1, h2
are of typeHeader
. This is becauseHeader
contains the special fieldnoCopy
, which triggersgovet
. To appeasegovet
, we can pass pointers toreflect.DeepEqual(&h1, &h2)
. According to the documentation, we can do this without breaking tests because "Pointer values are deeply equal if they are equal using Go's == operator or if they point to deeply equal values."