Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mod file #14

Merged
merged 1 commit into from
Mar 5, 2019
Merged

add mod file #14

merged 1 commit into from
Mar 5, 2019

Conversation

urandom2
Copy link
Contributor

@urandom2 urandom2 commented Mar 3, 2019

  • go modules will be enabled in 1.13
  • go mod tidy was also run to include required dependencies
  • after merge it would be nice if you would tag this repo: e.g. v1.0.0
    • this will allow consumers something more consistent and readable than v0.0.0-20170224212429-dcecefd839c4

This was referenced Mar 3, 2019
Merged
Merged
valyala
valyala approved these changes Mar 5, 2019
View reviewed changes
Copy link
Owner

@valyala valyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request

@valyala valyala merged commit 189f40e into valyala:master Mar 5, 2019
@valyala
Copy link
Owner

valyala commented Mar 5, 2019

Added tag v1.0.0

@urandom2 urandom2 deleted the upstream branch March 5, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valyala valyala valyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urandom2 @valyala