issue mongoid#34, handle nil value of original value of embedded rela…

…tion
vanboom · Jul 22, 2020 · d56491a · d56491a
1 parent 46c1804
commit d56491a
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/lib/mongoid/history/attributes/update.rb b/lib/mongoid/history/attributes/update.rb
@@ -90,14 +90,8 @@ def embeds_many_changes_from_parent(relation, value)
           relation = trackable_class.database_field_name(relation)
           relation_class = trackable_class.relation_class_of(relation)
           paranoia_field = Mongoid::History.trackable_class_settings(relation_class)[:paranoia_field]
-
-          # DVB only process if the original value of the embedded relation is not nil
-          original_value = if value[0].present?
-            value[0].reject { |rel| rel[paranoia_field].present? }
-              .map { |v_attrs| format_embeds_many_relation(relation, v_attrs) }
-            else
-              nil
-            end
+          original_value = (value[0] || []).reject { |rel| rel[paranoia_field].present? }
+                                   .map { |v_attrs| format_embeds_many_relation(relation, v_attrs) }
           modified_value = value[1].reject { |rel| rel[paranoia_field].present? }
                                    .map { |v_attrs| format_embeds_many_relation(relation, v_attrs) }
           return if original_value == modified_value