Updating Trackable::association_hash to write through parent. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are cases (on destroy mianly) where an child document would write it's class name to the association_hash 'name' field. This happens when it fails to lookup the relationship meta information pertaining to it's parent OR when the child has been deleted off the parent record before the destroy history track has been written. Then if you are trying to use that history track later on, it would fail the to be able to lookup it's trackable_parent, among other methods, because it would try to traverse a relationship titled "Comment" instead of the actual name of teh association, 'comments'. This fix makes it so a child document doesn't fail to lookup the name of the relation, when a parent is present, regardless of when the delete occurs.
|
|
||
| inverse = node._parent.reflect_on_association(meta.inverse) if meta | ||
| #We prefer to look up associations through the parent record because |
There was a problem hiding this comment.
Sorry to be picky, could you please fix spelling in this comment (exist is misspelled exsist) and add a space after a # :) thx.
|
Good. I'll merge it after the comment fixes. Thanks. |
|
@dblock Sorry about the typos. Let me know if there's anything else. |
|
Merging this, /cc: @aq1018 |
dblock
added a commit
that referenced
this pull request
May 1, 2012
Updating Trackable::association_hash to write through parent.
|
thanks! @dblock! |
|
@dblock, are you able to release the gem? I've been caught up in a few projects and getting quite busy lately. |
vanboom
added a commit
to vanboom/mongoid-history
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are cases (on destroy mianly) where an child document
would write it's class name to the association_hash 'name' field. This
happens when it fails to lookup the relationship meta information pertaining to it's
parent OR when the child has been deleted off the parent record before
the destroy history track has been written.
Then if you are trying to use that history track later on, it would fail
the to be able to lookup it's trackable_parent, among other methods,
because it would try to traverse a relationship titled "Comment"
instead of the actual name of teh association, 'comments'.
This fix makes it so a child document doesn't fail to lookup the name of
the relation, when a parent is present, regardless of when the delete
occurs.