Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use darker colors for artist images #984

Merged
merged 3 commits into from
Jan 19, 2020

Conversation

mueller-ma
Copy link
Contributor

Fixes #983

Fixes vanilla-music#983

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@adrian-bl
Copy link
Member

Is this based on an official color palette?

We are currently using the material color palette - which seems to be a sane choice for android.

@mueller-ma
Copy link
Contributor Author

I used a website to make the colors 20% darker. Some of them 40%, because 20% wasn't enough.
You're talking about the color table on https://material.io/design/color/the-color-system.html ? I wasn't aware the current colors are based on these colors.
I can update the new dark colors according to the material color palettes.

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Copy link
Contributor Author

@adrian-bl I updated the colors. The dark colors are now based on material colors if the bright equivalent is also a material color.

@adrian-bl
Copy link
Member

thanks, but could you also update 'generate-themes.pl' which is used to assemble the theme XML files?

Did you also test this on api versions < v21?

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@mueller-ma
Copy link
Contributor Author

thanks, but could you also update 'generate-themes.pl' which is used to assemble the theme XML files?

Done!

Did you also test this on api versions < v21?

No, I didn't. I try to find a device <v21 with music on it.

@mueller-ma
Copy link
Contributor Author

No, I didn't. I try to find a device <v21 with music on it.

I haven't found a suitable device.

@adrian-bl
Copy link
Member

I found an android 4.4 device and things seem to work fine - merging.
Thanks!

@adrian-bl adrian-bl merged commit fdec4d5 into vanilla-music:master Jan 19, 2020
@mueller-ma mueller-ma deleted the darker-icons branch January 19, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Darker colors for artist images on dark themes
2 participants