-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VNLA-6196: Add strings for automation rules dashboard pages #762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
site_core
changes included in your PR for arabic, don't think it should be part of it ?
tx-source/dash_core.php
Outdated
$Definition['Auto-run enabled.'] = 'Auto-run enabled.'; | ||
$Definition['Automation rule successfully created.'] = 'Automation rule successfully created.'; | ||
$Definition['Automation rule successfully updated.'] = 'Automation rule successfully updated.'; | ||
$Definition['Back'] = 'Back'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we already have a translation for this? If yes, no need to duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed duplicate in d977eec
tx-source/dash_core.php
Outdated
$Definition['Bump the discussion'] = 'Bump the discussion'; | ||
$Definition['Change the status of the idea to'] = 'Change the status of the idea to'; | ||
$Definition['Close the discussion'] = 'Close the discussion'; | ||
$Definition['Collapse'] = 'Collapse'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we already have a translation for this? If yes, no need to duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed duplicate in d977eec
$Definition['Create and manage automations to easily manage posts and users.'] = 'Create and manage automations to easily manage posts and users.'; | ||
$Definition['Create/Edit Automation Rule'] = 'Create/Edit Automation Rule'; | ||
$Definition['Edit Variables'] = 'Edit Variables'; | ||
$Definition['Expand'] = 'Expand'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we already have a translation for this? If yes, no need to duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find an existing translation for "Expand".
$Definition['Trigger'] = 'Trigger'; | ||
$Definition['Unsaved Changes'] = 'Unsaved Changes'; | ||
$Definition['Value is not a valid integer.'] = 'Value is not a valid integer.'; | ||
$Definition['with'] = 'with'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we already have a translation for this? If yes, no need to duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find an existing translation for "with".
https://higherlogic.atlassian.net/browse/VNLA-6196