Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNLA-6196: Add strings for automation rules dashboard pages #762

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

abrahamian
Copy link
Contributor

@abrahamian abrahamian commented Jun 3, 2024

@abrahamian abrahamian requested a review from a team June 3, 2024 18:25
Copy link
Contributor

@hhovhannes hhovhannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site_core changes included in your PR for arabic, don't think it should be part of it ?

$Definition['Auto-run enabled.'] = 'Auto-run enabled.';
$Definition['Automation rule successfully created.'] = 'Automation rule successfully created.';
$Definition['Automation rule successfully updated.'] = 'Automation rule successfully updated.';
$Definition['Back'] = 'Back';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we already have a translation for this? If yes, no need to duplicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed duplicate in d977eec

$Definition['Bump the discussion'] = 'Bump the discussion';
$Definition['Change the status of the idea to'] = 'Change the status of the idea to';
$Definition['Close the discussion'] = 'Close the discussion';
$Definition['Collapse'] = 'Collapse';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we already have a translation for this? If yes, no need to duplicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed duplicate in d977eec

$Definition['Create and manage automations to easily manage posts and users.'] = 'Create and manage automations to easily manage posts and users.';
$Definition['Create/Edit Automation Rule'] = 'Create/Edit Automation Rule';
$Definition['Edit Variables'] = 'Edit Variables';
$Definition['Expand'] = 'Expand';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we already have a translation for this? If yes, no need to duplicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an existing translation for "Expand".

$Definition['Trigger'] = 'Trigger';
$Definition['Unsaved Changes'] = 'Unsaved Changes';
$Definition['Value is not a valid integer.'] = 'Value is not a valid integer.';
$Definition['with'] = 'with';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we already have a translation for this? If yes, no need to duplicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find an existing translation for "with".

@abrahamian abrahamian changed the base branch from transifex to master June 3, 2024 18:38
@abrahamian abrahamian changed the base branch from master to transifex June 4, 2024 15:52
@abrahamian abrahamian merged commit 34cc21c into transifex Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants