Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width in popups with the richEditor mounted #10289

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

igraziatto
Copy link
Contributor

Closes https://github.com/vanilla/support/issues/1257

Steps to test:

  • You can have keystone or any other theme enabled, go to a discussion and click on "Flag" and then "Warn"
  • A full width popup will display, with the richEditor mounted.
  • Checkout this branch and repeat the steps above, the popup should have a max of 600px on large screens and full width on mobile.

@igraziatto igraziatto requested review from danni-stark and a team March 25, 2020 17:08
@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #10289 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10289   +/-   ##
=========================================
  Coverage     53.35%   53.35%           
  Complexity     7846     7846           
=========================================
  Files           363      363           
  Lines         43964    43964           
=========================================
  Hits          23457    23457           
  Misses        20507    20507           

@nervoustwit nervoustwit self-requested a review March 25, 2020 20:18
Copy link
Contributor

@nervoustwit nervoustwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good.

@danni-stark danni-stark merged commit eef14d4 into master Mar 26, 2020
@charrondev charrondev deleted the fix/richeditor-popup-size branch February 4, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants