Logging enhancements #10564
Merged
Logging enhancements #10564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10564 +/- ##
=========================================
Coverage 55.80% 55.80%
Complexity 7741 7741
=========================================
Files 395 395
Lines 44904 44904
=========================================
Hits 25058 25058
Misses 19846 19846 |
This is only so some models can control internal settings such as capture only.
- Deprecate `ensureSchemas()` in favor of dedicated read and write schemas. - Deprecate `get()` in favor of `select()`. - Deprecate `sql()` in favor of `createSql()`.
…illa into feature/logging-enhancements
…illa into feature/logging-enhancements
This will make the static method match our team’s new convention to load all trait setup methods at once.
Channel is way cooler.
The idea is to collect all possible actions in one place to keep things consistent.
…illa into feature/logging-enhancements
tburry
commented
May 19, 2020
…illa into feature/logging-enhancements
…illa into feature/logging-enhancements
initvector
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lot of logging enhancements and code cleanup around them.
Modelclass and add some primary key information.