Prevent manipulation of field Form when posting discussion/comments #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'Format' to the fields that are filtered out from POST data. By now it is possible to spoof the post data to set Format to whatever you like. So malicious users can override Garden.InputFormatter settings on individual basis. Although I think that this is no big issues, users shouldn't be able to add arbitrary text to columns where they shouldn't be able to insert *anything* on their own
R-J
changed the title
|
Hey RJ. This is a great find. We will just need to find a different way of solving this issue. Since this method will certainly cause problems with the advanced editor. We suggest something more like: #2123 If you could help me complete and test this we can look at getting into core ASAP. |
|
Your alternative would still allow anyone to post html when only text (e.g.) should be allowed. I do not know how the advanced editor is working, so it's hard to think about alternatives ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'Format' to the fields that are filtered out from POST data.
By now it is possible to spoof the post data to set Format to whatever you like. So malicious users can override Garden.InputFormatter settings on individual basis. Although I think that this is no big issues, users shouldn't be able to add arbitrary text to columns where they shouldn't be able to insert anything on their own