Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Advanced Editor to core. #2108

Closed
wants to merge 1 commit into from
Closed

Move Advanced Editor to core. #2108

wants to merge 1 commit into from

Conversation

linc
Copy link
Contributor

@linc linc commented Sep 20, 2014

Addresses #2044

@R-J
Copy link
Contributor

R-J commented Sep 26, 2014

I was looking at how much work it would be to backport Advanced Editor to 2.1 and I got a "Fatal error: Class 'Emoji' not found", while there is "'RequiredPlugins' => false," in the config.

Also I guess that this might not be Emoji from vf.org and so you might have to either release one more plugin or have to cut out that dependency.

@R-J
Copy link
Contributor

R-J commented Sep 26, 2014

Forget about it! I found the class in core...

@tburry
Copy link
Contributor

tburry commented Sep 26, 2014

If you backported Emoji to 2.1 that would be amazing. Please note that our
current staging branch also has some changes with regards to the editor and
emoji. We'll be merging those into master soon (like hopefully today).

On Fri, Sep 26, 2014 at 5:43 AM, R-J notifications@github.com wrote:

Forget about it! I found the class in core...


Reply to this email directly or view it on GitHub
#2108 (comment).

@R-J
Copy link
Contributor

R-J commented Sep 27, 2014

@tburry: class.emoji.php seems not to be a problem.

$emoji = Emoji::instance();
echo $emoji->translateToHtml('test :)');

That works like expected. Also the other functions in this class have no Vanilla 2.2 (or above) specific functions.

@linc
Copy link
Contributor Author

linc commented Sep 30, 2014

Needs a new PR; got it out of sync waiting for this to land

@linc linc closed this Sep 30, 2014
@tburry
Copy link
Contributor

tburry commented Sep 30, 2014

I know I have to do more work on the advanced editor in the near future so
now might not be the time.

On Tue, Sep 30, 2014 at 1:22 PM, Lincoln Russell notifications@github.com
wrote:

Closed #2108 #2108.


Reply to this email directly or view it on GitHub
#2108 (comment).

@linc linc deleted the move/editor branch January 27, 2015 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants