Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop attribute "type" for style tags #4804

Merged
merged 5 commits into from Jan 3, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/dashboard/views/email/src/email-basic.php
Expand Up @@ -192,7 +192,7 @@
</style>
<!--[if (gte mso 9)|(IE)]>
[[literal]]
<style type="text/css">
<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some email clients are not yet HTML5 compliant, so I don't feel comfortable removing this yet.

table {
border-collapse: collapse;
}
Expand Down
Expand Up @@ -784,7 +784,7 @@ public function embed($DiscussionID = '', $DiscussionStub = '', $Offset = '', $L

// Add some css to help with the transparent bg on embedded comments
if ($this->Head) {
$this->Head->addString('<style type="text/css">
$this->Head->addString('<style>
body { background: transparent !important; }
</style>');
}
Expand Down
2 changes: 1 addition & 1 deletion container.html
Expand Up @@ -126,7 +126,7 @@
}
});
</script>
<style type="text/css">
<style>
html, body {
background-color: transparent;
overflow: hidden;
Expand Down