Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sql extraction in case of non-markdown response or CTE #350

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

Aymane11
Copy link
Contributor

This PR adds two sql extraction methods:

1 - Extract SQL query from non-markdown responses, extracting the query between SELECT and ;
2 - Extract SQL query containing CTE (WITH clause), extracting the query between WITH and ;

Also it removes the f-string from strings with no placeholders (like f"Hello World")

@zainhoda zainhoda merged commit e167f2f into vanna-ai:main Apr 12, 2024
@Aymane11 Aymane11 deleted the extract-sql-non-markdown-response branch October 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants