Fix emoji only filter #393

mario · 2019-10-03T07:30:24Z

Previously, when you enabled emoji-only filter and focused the edittext the emoji popup would appear.

In the future, when you tried focusing it for the second time only a keyboard would open as in reality edittext is already focused.

We now clear the focus after dismissing the emoji popup in case keyboard input is disabled.

Signed-off-by: Mario Danic <mario@lovelyhq.com>

mario · 2019-10-03T10:04:14Z

@vanniktech mind fixing the warnings here?

vanniktech · 2019-10-03T13:07:16Z

@mario I can do that once you're rebased

Signed-off-by: Mario Danic <mario@lovelyhq.com>

mario · 2019-10-14T19:41:34Z

@rubengees fancy fixing warnings? My head is a mess today.

rubengees · 2019-10-15T19:50:42Z

@mario Sure, done.

rubengees · 2019-10-15T19:53:00Z

I found a way to break out of the emoji picker and show a normal keyboard.

Steps:

Open keyboard.
Open input method dialog (for me on Android 10 in the bottom right).
Select other keyboard.

rubengees · 2019-10-15T20:11:10Z

PMD reports the EmojiPopup as a possible god class now due to it's size, that might be harder to fix...

vanniktech · 2019-10-16T07:34:52Z

Ignore it

vanniktech · 2019-10-16T15:46:51Z

emoji/build.gradle

@@ -23,6 +23,7 @@ dependencies {
  testImplementation rootProject.ext.testing.assertJ
  testImplementation rootProject.ext.testing.robolectric
  testImplementation rootProject.ext.testing.privateConstructor
+  androidTestAnnotationProcessor deps.support.test.autoService


What do we need this for?

One of the lints complained about it missing.

vanniktech · 2019-10-16T15:46:54Z

build.gradle

@@ -100,7 +101,8 @@ ext {
          junit             : 'junit:junit:4.13-beta-3',
          robolectric       : 'org.robolectric:robolectric:4.3.1',
          privateConstructor: 'com.pushtorefresh.java-private-constructor-checker:checker:1.2.0',
-          assertJ           : 'org.assertj:assertj-core:2.9.1'
+          assertJ           : 'org.assertj:assertj-core:2.9.1',
+          autoService       : 'com.google.auto.service:auto-service:1.0-rc4'


vanniktech · 2019-10-16T15:47:00Z

app/build.gradle

@@ -68,6 +68,7 @@ dependencies {
  androidTestImplementation deps.support.test.runner
  androidTestImplementation deps.support.test.rules
  androidTestImplementation deps.fastLaneScreenGrab
+  androidTestAnnotationProcessor deps.support.test.autoService


mario · 2019-10-16T15:50:04Z

I found a way to break out of the emoji picker and show a normal keyboard.

Steps:

Open keyboard.

Open input method dialog (for me on Android 10 in the bottom right).

Select other keyboard.

@vanniktech did you test this? Since I don't even see the input method dialog?

vanniktech · 2019-10-16T15:50:46Z

did you test this? Since I don't even see the input method dialog?

Not yet

vanniktech · 2019-10-17T10:19:37Z

I found one way:

Check the checkbox
Click on the input field
Click on the dialog button
Dismiss the dialog
Click on the input field (Normal keyboard is shown instead of the emoji one)

mario · 2019-10-23T13:09:22Z

Should be ok now @vanniktech and @rubengees

Signed-off-by: Mario Danic <mario@lovelyhq.com>

vanniktech

Tested and this works. Nice work! Let's wait until @rubengees also approves

vanniktech · 2019-10-27T12:45:41Z

@rubengees @mario how should we proceed with PR's so that they don't stay open that long?

I propose:

At least one review
Waiting for a second review for up to 3 days

mario · 2019-10-28T14:49:24Z

Well in general I'm highly in favour of at least two reviews, but I guess we need a policy on how long we wait. I feel like 3 days is too little? How does 7 days work for you two?

vanniktech · 2019-10-28T14:50:37Z

Sure. I'm fine with 7 days!

vanniktech · 2019-11-06T21:16:56Z

I'll merge this now as discussed with @mario.

rubengees · 2019-11-07T16:49:34Z

Sorry for being away so long, I agree regarding the proposed time for waiting.

vanniktech · 2019-11-07T22:49:12Z

No need to be sorry. I hope everything is fine @ruben

rubengees · 2019-11-08T07:50:22Z

Yes sure, was just a bit lazy in the last time 😄

mario and others added 8 commits October 2, 2019 12:40

Cherry

24474b9

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix all the issues

7c152f3

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Update readme

ac299c7

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Optimize imports

c91c0c6

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix lint issues

0fb8abb

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix build.

43d0be0

Still target 28 and fix weird E letter.

ae31690

Fix popup management

d87c862

Signed-off-by: Mario Danic <mario@lovelyhq.com>

mario requested review from vanniktech and rubengees October 3, 2019 07:30

mario added 4 commits October 3, 2019 09:45

Fix CR stuff

7902c4a

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fixx issues with offset thing

abf0caa

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix emoji-only filter

ad3b1f1

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix lint warning

1868718

Signed-off-by: Mario Danic <mario@lovelyhq.com>

mario force-pushed the fix-emoji-only-filter branch from d31c787 to 1868718 Compare October 3, 2019 08:18

Fix warnings

a55662c

Signed-off-by: Mario Danic <mario@lovelyhq.com>

mario added 2 commits October 14, 2019 19:57

Merge branch 'master' into fix-emoji-only-filter

e77823d

Update post merge

43f6a04

Signed-off-by: Mario Danic <mario@lovelyhq.com>

Fix warnings

52c2c34

Merge branch 'master' into fix-emoji-only-filter

6de2568

Ignore PMD warning.

5f5de32

vanniktech approved these changes Oct 16, 2019

View reviewed changes

vanniktech previously approved these changes Oct 16, 2019

View reviewed changes

mario dismissed vanniktech’s stale review via a8fde45 October 23, 2019 13:09

Fix issues

a8fde45

Signed-off-by: Mario Danic <mario@lovelyhq.com>

vanniktech approved these changes Oct 23, 2019

View reviewed changes

vanniktech merged commit 489bd66 into master Nov 6, 2019

vanniktech deleted the fix-emoji-only-filter branch November 6, 2019 21:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix emoji only filter #393

Fix emoji only filter #393

mario commented Oct 3, 2019

mario commented Oct 3, 2019

vanniktech commented Oct 3, 2019

mario commented Oct 14, 2019

rubengees commented Oct 15, 2019

rubengees commented Oct 15, 2019

rubengees commented Oct 15, 2019

vanniktech commented Oct 16, 2019

vanniktech Oct 16, 2019

mario Oct 16, 2019

vanniktech Oct 16, 2019

vanniktech Oct 16, 2019

mario commented Oct 16, 2019

vanniktech commented Oct 16, 2019

vanniktech commented Oct 17, 2019

mario commented Oct 23, 2019

vanniktech left a comment

vanniktech commented Oct 27, 2019

mario commented Oct 28, 2019

vanniktech commented Oct 28, 2019

vanniktech commented Nov 6, 2019

rubengees commented Nov 7, 2019

vanniktech commented Nov 7, 2019

rubengees commented Nov 8, 2019

Fix emoji only filter #393

Fix emoji only filter #393

Conversation

mario commented Oct 3, 2019

mario commented Oct 3, 2019

vanniktech commented Oct 3, 2019

mario commented Oct 14, 2019

rubengees commented Oct 15, 2019

rubengees commented Oct 15, 2019

rubengees commented Oct 15, 2019

vanniktech commented Oct 16, 2019

vanniktech Oct 16, 2019

Choose a reason for hiding this comment

mario Oct 16, 2019

Choose a reason for hiding this comment

vanniktech Oct 16, 2019

Choose a reason for hiding this comment

vanniktech Oct 16, 2019

Choose a reason for hiding this comment

mario commented Oct 16, 2019

vanniktech commented Oct 16, 2019

vanniktech commented Oct 17, 2019

mario commented Oct 23, 2019

vanniktech left a comment

Choose a reason for hiding this comment

vanniktech commented Oct 27, 2019

mario commented Oct 28, 2019

vanniktech commented Oct 28, 2019

vanniktech commented Nov 6, 2019

rubengees commented Nov 7, 2019

vanniktech commented Nov 7, 2019

rubengees commented Nov 8, 2019