Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to run algorithms without data. #465

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Added option to run algorithms without data. #465

merged 3 commits into from
Jan 16, 2023

Conversation

mellesies
Copy link
Contributor

Required minimal modification to wrapper. Is backwards compatible.

frankcorneliusmartin
frankcorneliusmartin approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I think we should remove the data argument from the RPC method then aswell (as it should not be used anyways)

@bartvanb bartvanb changed the base branch from main to dev3 January 13, 2023 16:07
@frankcorneliusmartin frankcorneliusmartin merged commit 0c59f11 into dev3 Jan 16, 2023
@frankcorneliusmartin frankcorneliusmartin deleted the feature/dataless-wrapper branch January 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcorneliusmartin frankcorneliusmartin frankcorneliusmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mellesies @frankcorneliusmartin