Feature/start UI with vserver #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding options to config file to start it - Added documentation - minor improvements to code
frankcorneliusmartin
approved these changes
Jul 13, 2023
vantage6/vantage6/cli/globals.py
Outdated
| @@ -35,3 +35,6 @@ | |||
|
|
|||
| # Maximum time to start up RabbitMQ in seconds | |||
| RABBIT_TIMEOUT = 300 | |||
|
|
|||
| # Default port to start the UI on | |||
| DEFAULT_UI_PORT = 4200 | |||
There was a problem hiding this comment.
Why 4200? I know it does not matter, but ill forget this. Could we make it 5001 of 5555?
There was a problem hiding this comment.
4200 is just the default port for an Angular app, but indeed that is not obvious to the average vantage6 user. I changed it to 5001, so that is right next to the default v6 server port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #730