Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tabCapture API #123

Closed
3 of 4 tasks
vantezzen opened this issue Jul 2, 2022 · 0 comments
Closed
3 of 4 tasks

Use tabCapture API #123

vantezzen opened this issue Jul 2, 2022 · 0 comments

Comments

@vantezzen
Copy link
Owner

vantezzen commented Jul 2, 2022

Currently, the extension uses direct media element access to analyze the volume. To improve issues with CORS, this can instead be changed to work on a per-page basis using the Chrome "tabCapture" API.

Pros

  • Makes the extension work on far more pages (especially CORS-related issues)
  • May even work on pages that don't use the standard HTML5 audio elements when adding custom page drivers

Cons

  • This change is NOT compatible with Firefox
    • The feature uses the "tabCapture" API which is not implemented in Firefox and won't get in the near future (https://bugzilla.mozilla.org/show_bug.cgi?id=1391223)
    • I plan on keeping support for the current Skip Silence 4, keeping compatibility with Firefox but not having background-level capturing or making the extension compatible with both APIs based on availability
  • This change is (currently) NOT compatible with Manifest v3
  • multiple media elements on a SINGLE page cannot be analyzed independently, though I doubt anyone uses Skip silence like that

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant