Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Silence 5 #97

Merged
merged 61 commits into from
Sep 23, 2022
Merged

Skip Silence 5 #97

merged 61 commits into from
Sep 23, 2022

Conversation

vantezzen
Copy link
Owner

@vantezzen vantezzen commented Jan 17, 2022

Skip Silence 5 is the next large update for Skip Silence, bringing new features to the extension.

Features:

@rolltidehero
Copy link

Awesome. Can't wait! I think I'm going to go ahead and buy it now.


return {
responseHeaders: details.responseHeaders,
Copy link

@WofWca WofWca May 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a security issue. If it is to be implemented, I think users at least need to know and understand what they're signing up for.
https://webaudio.github.io/web-audio-api/#MediaElementAudioSourceOptions-security

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. The current implementation is only for testing, and I'll probably be removing the complete CORS unblock mechanism as it doesn't really fix the "MediaElementAudioSource outputs zeroes due to CORS access restrictions" as I hoped it would

@vantezzen
Copy link
Owner Author

Unfortunately, I can't seem to find a way to circumvent the CORS restrictions for streaming. Theoretically, I should be able to remove all these restrictions as I'm running in a privileged web extension environment, but I get CORS errors every time - even when loading from the background page.

@vantezzen vantezzen marked this pull request as ready for review September 23, 2022 07:59
@vantezzen vantezzen merged commit d65943f into master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants