Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Singleplex Polaris app #15

Merged
merged 32 commits into from Feb 1, 2022
Merged

Singleplex Polaris app #15

merged 32 commits into from Feb 1, 2022

Conversation

elaubsch
Copy link
Member

@elaubsch elaubsch commented Jan 27, 2022 •
edited

Adding the singleplex application, which will now be referred to as the Polaris application. The previous iteration of the Polaris application (without cell segmentation) has been refactored to the SpotDetection application.

msschwartz21
msschwartz21 requested changes Jan 27, 2022
View reviewed changes
Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple places where you are using triple quotes outside of the docstring. I'd prefer that those are changed to single quotes if possible.

I think the only major change to the new application regards handling of loading the models.

deepcell_spots/applications/polaris.py Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/spot_detection.py Outdated Show resolved Hide resolved
deepcell_spots/applications/spot_detection.py Outdated Show resolved Hide resolved
elaubsch and others added 13 commits January 27, 2022 15:12
@elaubsch @msschwartz21
Update whitespace
a443cce 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch @msschwartz21
Remove comment
b731f6f 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch @msschwartz21
Remove comment
ecf90b0 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch @msschwartz21
Update deepcell_spots/applications/polaris.py
6f103d0 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch @msschwartz21
Update deepcell_spots/applications/polaris.py
4ad3da1 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch @msschwartz21
Triple quotes to single quotes
694262b 
Co-authored-by: Morgan Schwartz <msschwartz21@gmail.com>
@elaubsch
Rename _predict_segmentation to _predict
6c00c0a
@elaubsch
Merge branch 'singleplex-app' of https://github.com/vanvalenlab/deepc…
760e4ca 
…ell-spots into singleplex-app
@elaubsch
Remove model
3a874e7
@elaubsch
Rename spots variables
ef713f0
@elaubsch
Update segmentation model
3079d66
@elaubsch
Add nuclear segmentation
d7552c6
@elaubsch
Test errors
c5b51f8
msschwartz21
msschwartz21 requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much ready to go. Comments are mostly just getting the docs to match current behavior.

deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/applications/polaris.py Show resolved Hide resolved
deepcell_spots/applications/polaris.py Outdated Show resolved Hide resolved
deepcell_spots/preprocessing_utils.py Outdated Show resolved Hide resolved
@elaubsch elaubsch merged commit 3242b91 into master Feb 1, 2022
@elaubsch elaubsch deleted the singleplex-app branch February 1, 2022 23:27
@msschwartz21 msschwartz21 added the enhancement New feature or request label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msschwartz21 msschwartz21 msschwartz21 requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elaubsch @msschwartz21