Allow blank images in training data set #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Just two nits:
- Using the kwarg name
fill_value=makes the call slightly more grokable. - Passing in the dtype is slightly more efficient than coercing the array to the desired dtype after creating the array.
Neither of these is important - feel free to ignore!
At some point we should investigate if we can't speed this up using e.g. scipy.spatial, especially if this is used with large image_shapes and/or lots of points. Not relevant for now though, LGTM!
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a known bug in
subpixel_distance_transformthat prevented images without spots from being included in the training data set for the spot detection model.subpixel_distance_transformnow checks the length of inputpoint_listand if its length is zero, it returns a null result. This PR also adds a test for the no spots case forsubpixel_distance_transform.