Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mixture of Gaussians to decoding distributions #49

Merged
merged 20 commits into from Mar 23, 2023
Merged

Add mixture of Gaussians to decoding distributions #49

merged 20 commits into from Mar 23, 2023

Conversation

elaubsch
Copy link
Member

@elaubsch elaubsch commented Mar 4, 2023 •
edited

This PR adds mixture of Gaussians as an option in params_mode. These changes include:

  • Addition of decoding functions adapted from PoSTcode (https://github.com/gerstung-lab/postcode).
  • Exposing params_mode as an argument for the Polaris application
  • Addition of logic to use raw pixel values when params_mode=='Gaussian' and probability values otherwise
  • More extensive testing of applications and decoding functions

@elaubsch elaubsch added the enhancement New feature or request label Mar 4, 2023
rossbar
rossbar approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor comments!

deepcell_spots/decoding_functions.py Outdated Show resolved Hide resolved
deepcell_spots/decoding_functions.py Outdated Show resolved Hide resolved
deepcell_spots/decoding_functions.py Show resolved Hide resolved
@elaubsch elaubsch merged commit a1cea41 into master Mar 23, 2023
5 checks passed
@elaubsch elaubsch deleted the mly/postcode branch March 23, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elaubsch @rossbar