Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement correct usage of crop parameter in CellTracker #108

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Implement correct usage of crop parameter in CellTracker #108

merged 4 commits into from
Dec 20, 2022

Conversation

msschwartz21
Copy link
Member

  • Corrects an error where the crop parameter was not being set during tracking and inference
  • Removes deprecated post processing functions from the CellTracker

@msschwartz21 msschwartz21 added the fix Fixes a bug label Dec 20, 2022
@msschwartz21 msschwartz21 mentioned this pull request Dec 20, 2022
Merged
@msschwartz21
Copy link
Member Author

In order to address the issue with numpy 1.24, I am going to pin to <1.24 and have opened an issue for the necessary future updates #109.

rossbar
rossbar approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It'd be nice to add tests for the crop_mode and norm parameters, but I haven't had a chance to look too closely at the test suite here so it's not a blocker.

I trust your expertise on the removed methods!

@msschwartz21 msschwartz21 merged commit 199dde2 into master Dec 20, 2022
@msschwartz21 msschwartz21 deleted the mrgn/crop-modes branch December 20, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msschwartz21 @rossbar