Mibi consumer updated #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgraf
requested changes
Jun 25, 2020
willgraf
requested changes
Jun 28, 2020
willgraf
reviewed
Jun 29, 2020
|
I've made some updates to the testing patterns. I recommend pulling in the master branch and adapting your tests to use the The new tests are much more robust and easier to write. |
|
We should also refactor |
* Improved testing coverage using fakeredis and pytest-mock (#117) * install pytest-mock and replace monkeypatching with `mock` library. * move testing reqs into requirements-test.txt and add 3.8 to test suite. * update RedisClient tests to use fakeredis. * directly patch boto3.client * no need to alias google.cloud.storage in imports. * Fix storage tests to use a Singleton dummy class instead of global variables. * proper string fomatting using {} instead of %s * move DummyStorage and DummyRedis into utils/testing_utils.py to DRY out the tests * Update tests to use fakeredis client and fewer global variables. * use save_output for ImageConsumer and MibiConsumer. pass save_name into the function directly instead of calling HGETALL inside the save_output function. * inherit from ImageFileConsumer to make better use of the pre/post-process functions. * add keys for the mibi pre and postprocessing. * adapt the mibi consumer tests to use the testing_utils.py helpers. * remove unused imports. * Fix a few license URLs. (#118)
…b/kiosk-redis-consumer into mibi-consumer-updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mibi consumer and mibi consumer tests