Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHS-NG M2: Store FsHistoryProvider listing data in LevelDB. #4

Closed
wants to merge 3 commits into from
Closed

SHS-NG M2: Store FsHistoryProvider listing data in LevelDB. #4

wants to merge 3 commits into from

Commits on May 26, 2017

  1. SHS-NG M1: small fix in loop condition.

    Marcelo Vanzin committed May 26, 2017
    Configuration menu
    Copy the full SHA
    c433065 View commit details
    Browse the repository at this point in the history

  2. SHS-NG M1.2: In-memory KVStore implementation. 

    This change adds an in-memory implementation of KVStore that can be
used by the live UI.

The implementation is definitely not optimized, neither for speed nor
space, but should be fast enough for using in the listener bus.

The change slightly changes the semantics of KVStore views; now, by
default, they don't guarantee ordering, which makes it faster to
iterate over data in the in-memory store when trimming the number
of elements (a feature that will be useful later on). The disk store
by default still returns elements in sorted order.
    Marcelo Vanzin committed May 26, 2017
    Configuration menu
    Copy the full SHA
    667baf2 View commit details
    Browse the repository at this point in the history

  3. SHS-NG M2: Store FsHistoryProvider listing data in a KVStore. 

    The application listing is still generated from event logs, but is now stored
in a KVStore instance. By default an in-memory store is used, but a new config
allows setting a local disk path to store the data, in which case a LevelDB
store will be created.

The provider stores things internally using the public REST API types; I believe
this is better going forward since it will make it easier to get rid of the
internal history server API which is mostly redundant at this point.

I also added a finalizer to LevelDBIterator, to make sure that resources are
eventually released. This helps when code iterates but does not exhaust the
iterator, thus not triggering the auto-close code.

HistoryServerSuite was modified to not re-start the history server unnecessarily;
this makes the json validation tests run more quickly.
    Marcelo Vanzin committed May 26, 2017
    Configuration menu
    Copy the full SHA
    2fa4f3f View commit details
    Browse the repository at this point in the history