Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #23

Merged
merged 4 commits into from
May 18, 2017
Merged

Update Package.swift #23

merged 4 commits into from
May 18, 2017

Conversation

pruthvikar
Copy link
Contributor

Update Package.swift to use Vapor 2 release dependencies

Update Package.swift to use Vapor 2 release dependencies
Pinning using major version
@codecov-io
Copy link

codecov-io commented May 17, 2017

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #23   +/-   ##
====================================
  Coverage      24%   24%           
====================================
  Files           5     5           
  Lines         450   450           
====================================
  Hits          108   108           
  Misses        342   342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da290d...e0f3d87. Read the comment docs.

Copy link
Collaborator

@natebird natebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the PostgreSQL-Driver dependency to majorVersion: 2 and we will wait on merging this until PostgreSQL-Driver 2.0 is released.

Package.swift Outdated
@@ -6,8 +6,8 @@ let package = Package(
// PostgreSQL driver for Fluent
.Package(url: "https://github.com/vapor/postgresql-driver.git", Version(2,0,0, prereleaseIdentifiers: ["beta"])),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and change the postgresql-driver dependency to majorVersion: 2 as well. We can merge this PR when PostgreSQL-Driver hits 2.0.

pruthvikar and others added 2 commits May 17, 2017 23:15
Updated postgresql to major version 2
@vzsg vzsg merged commit 89cb315 into vapor-community:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants