Refactor websocket tests to use table testing style #23
Conversation
There was a problem hiding this comment.
I'm not sure it makes sense to merge this. While the changes themselves seem good, I don't think it makes sense to format these tests as a single table test. Mostly because each test case is testing something different (e.g. client.Status, client.Version, ...), so it makes sense for them to be in their own test cases.
It can get kinda messy having everything spread apart in their own case and having duplicate test code for the test execution portion, but it is ultimately more manageable/helpful. Consider if one test here failed -- it would be more difficult to determine where the failure happened since any failure would fail the entire test case. If they were left broken up as individual tests, one failure only fails that case, making it easier to identify.
I think the test table style is good when testing the same thing (e.g. function) with different parameters or conditions. I'm going to close the PR as a wontfix
No description provided.