Add SHA256 hashed cert X5C tests #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Oct 24, 2023
gwynne
added
enhancement
gwynne
approved these changes
Oct 27, 2023
scripts/create-jwt.py
Outdated
There was a problem hiding this comment.
There really wasn't anything wrong with the Python approach, by the way... 😅
There was a problem hiding this comment.
Either one is fine with me!
Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #99 requires X5C chain certificates to be hashed with something different than SHA1 (and the default
X5CTestsuse SHA1) this adds tests which use SHA256 hashed certificates. It also includes the scripts and commands used to generate those certificates, for anyone who might need them later on