Fix reference cycle in LeafEncoder #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused objects rendered in a view to be leaked, each time the view is rendered.
|
Any update on this? This project cannot be used in anything significant as long as this ref cycle exists. Caused me some headaches in my somewhat heavily used internal project, but I'm using my own branch for now. Let me know if something needs to change! |
0xTim
requested changes
Sep 27, 2022
| @@ -135,7 +135,7 @@ extension LeafEncoder { | |||
| } | |||
|
|
|||
| private final class KeyedContainerImpl<Key>: KeyedEncodingContainerProtocol, LeafEncodingResolvable where Key: CodingKey { | |||
| private let encoder: EncoderImpl | |||
| private weak var encoder: EncoderImpl! | |||
There was a problem hiding this comment.
We can't force unwrap these here - if they're weak then there's a chance that the reference will have been released when we try and use them, which will take down a server. So we'll need to check they exist where we use them
|
Closing in favour of #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused objects rendered in a view to be leaked, each time the view was rendered. This change breaks the reference cycle. A container should always be referenced by an encoder, so it should be safe to make the encoder reference weak, inside the container.
If anyone with more knowledge disagrees, please let me know what needs to change. Tested this in instruments, and it definitely fixes the cycle.