Fix retain cycle(s) in encoder implementation without adding any fatalError() #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #215 and serves as an alternative to #220 without adding any fatalError().
In order to confirm the fix, I have added debug output to the deinit method of EncoderImpl.
Running the test cases it clearly shows that when encoding via
try encoder.encode(encodable)the deinit gets called on every test case, whereas with the oldtry encodable.encode(to: encoder)that is not the case.The nested EncoderImpl are referenced weakly in a similar way as proposed in #220 in order to break retain cycles. However, instead of adding
fatalError()calls when the EncoderImpl is deallocated, an error will be thrown.