[WIP] Pull Vapor 4 changes over from vapor/vapor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tanner0101
reviewed
Oct 21, 2019
| @@ -0,0 +1,32 @@ | |||
| /// A basic `CodingKey` implementation. | |||
| public enum BasicCodingKey: CodingKey { | |||
There was a problem hiding this comment.
Does this need to be public here?
| /// "/" / "[" / "]" / "?" / "=" | ||
| /// ; Must be in quoted-string, | ||
| /// ; to use within parameter values | ||
| public struct HTTPHeaderValue: Codable { |
There was a problem hiding this comment.
Hmm do we really need this thing? Could we just return header values as String?
|
We should also be able to get CI working w/ the new GH actions stuff if we copy of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All work done by @tanner0101