Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multipart Coders Separated from Vapor #2080

Merged
merged 5 commits into from Oct 22, 2019
Merged

Multipart Coders Separated from Vapor #2080

merged 5 commits into from Oct 22, 2019

Conversation

twof
Copy link
Member

@twof twof commented Oct 16, 2019

We want to ship a separate multipart package to make it usable outside of Vapor. This should be shipped after vapor/multipart-kit#37

Checklist

  • Circle CI is passing (code compiles and passes tests).
  • There are no breaking changes to public API.
  • New test cases have been added where appropriate.
  • All new code has been commented with doc blocks ///.

@twof twof requested a review from tanner0101 October 16, 2019 00:25
@twof twof self-assigned this Oct 16, 2019
@tanner0101 tanner0101 marked this pull request as ready for review October 22, 2019 18:03
@tanner0101 tanner0101 added the enhancement New feature or request label Oct 22, 2019
@tanner0101 tanner0101 added this to In Progress in Vapor 4 via automation Oct 22, 2019
tanner0101
tanner0101 previously approved these changes Oct 22, 2019
View reviewed changes
@tanner0101 tanner0101 merged commit 8f6ef7c into master Oct 22, 2019
Vapor 4 automation moved this from In Progress to Done Oct 22, 2019
@tanner0101 tanner0101 deleted the ImportMultipart branch October 22, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 left review comments

Assignees

@twof twof

Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twof @tanner0101