Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily don't use HTTPClient.shared in GitHubAPI #188

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Temporarily don't use HTTPClient.shared in GitHubAPI #188

merged 1 commit into from
Apr 15, 2024

Conversation

MahdiBM
Copy link
Collaborator

@MahdiBM MahdiBM commented Apr 15, 2024 •
edited
Loading

@MahdiBM MahdiBM enabled auto-merge (squash) April 15, 2024 10:42
@MahdiBM MahdiBM merged commit bf86a01 into main Apr 15, 2024
10 of 12 checks passed
@MahdiBM MahdiBM deleted the mmbm-temp-ghapi-no-shared branch April 15, 2024 10:51
MahdiBM added a commit that referenced this pull request May 19, 2024
@MahdiBM
Revert "Temporarily don't use HTTPClient.shared in GitHubAPI (#188)"
908a1ee 
This reverts commit bf86a01.
MahdiBM added a commit that referenced this pull request May 24, 2024
@MahdiBM
Revert usage of HTTPClient.shared (#193)
54c7c3c 
* Revert "Temporarily don't use `HTTPClient.shared` in `GitHubAPI` (#188)"

This reverts commit bf86a01.

* Revert using `HTTPClient.shared`

* use a new shared configuration for Penny's HTTPClient's

* remove syncShutdown() s

* no need to try!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MahdiBM @gwynne