Revert usage of HTTPClient.shared
#193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf86a01.
0xTim
reviewed
May 20, 2024
0xTim
requested changes
May 20, 2024
0xTim
approved these changes
May 24, 2024
| @@ -49,7 +49,7 @@ actor DefaultAutoFaqsService: AutoFaqsService { | |||
| } | |||
| } | |||
|
|
|||
| let httpClient: HTTPClient = .shared | |||
| var httpClient: HTTPClient! | |||
| @@ -10,7 +10,7 @@ import NIOHTTP1 | |||
|
|
|||
| actor DefaultFaqsService: FaqsService { | |||
|
|
|||
| let httpClient: HTTPClient = .shared | |||
| var httpClient: HTTPClient! | |||
There was a problem hiding this comment.
There is a reason although i don't remember it off-hand.
There was a problem hiding this comment.
They are likely initialized first, then populated with the http client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert commits related to using
HTTPClient.shared.I don't think using the shared HTTPClient is necessary for Penny. It only moves Penny out of the control of the
HTTPClient.