Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary bandaid workaround for lack of PSQLError usefulness #244

Merged
merged 1 commit into from
May 16, 2023
Merged

Temporary bandaid workaround for lack of PSQLError usefulness #244

merged 1 commit into from
May 16, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 15, 2023

This is a temporary workaround while waiting for vapor/postgres-nio#360 to be finished.

@gwynne gwynne added the semver-patch Internal changes only label May 15, 2023
@gwynne gwynne requested a review from 0xTim May 15, 2023 09:37
@gwynne gwynne self-assigned this May 15, 2023
@gwynne gwynne added this to Awaiting Review in Vapor 4 via automation May 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #244 (d4068f6) into main (69d8595) will decrease coverage by 0.70%.
The diff coverage is 8.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   30.79%   30.09%   -0.70%     
==========================================
  Files          13       13              
  Lines         708      731      +23     
==========================================
+ Hits          218      220       +2     
- Misses        490      511      +21
Impacted Files Coverage Δ
Sources/PostgresKit/PostgresDatabase+SQL.swift 52.72% <0.00%> (-32.57%) ⬇️
Sources/PostgresKit/PostgresConnectionSource.swift 100.00% <100.00%> (ø)

@gwynne gwynne mentioned this pull request May 15, 2023
Merged
@gwynne gwynne merged commit 875e8c1 into main May 16, 2023
19 checks passed
Vapor 4 automation moved this from Awaiting Review to Done May 16, 2023
@gwynne gwynne deleted the psqlerror-debugdescription-bandaid branch May 16, 2023 06:46
@VaporBot
Copy link

These changes are now available in 2.11.2

@finestructure finestructure mentioned this pull request May 16, 2023
Open
gwynne added a commit that referenced this pull request Jun 9, 2023
@gwynne
Revert "Temporary bandaid workaround for lack of PSQLError usefulness (…
7c34671 
…#244)"

This reverts commit 875e8c1.
@gwynne gwynne mentioned this pull request Jun 9, 2023
Merged
gwynne added a commit that referenced this pull request Jun 9, 2023
@gwynne
Remove the temporary workaround for PSQLError descriptions (#245)
a88d025 
* Revert "Temporary bandaid workaround for lack of PSQLError usefulness (#244)"

This reverts commit 875e8c1.

* Ditch old and badly outdated file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees

@gwynne gwynne

Labels
semver-patch Internal changes only
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gwynne @codecov-commenter @VaporBot @0xTim