Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the temporary workaround for PSQLError descriptions #245

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jun 9, 2023

The workaround didn't work very well anyway (I got it slightly wrong), and thanks to vapor/postgres-nio#372 is no longer needed at all.

This reverts #244, commit 875e8c1.

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels Jun 9, 2023
@gwynne gwynne requested review from vzsg, 0xTim and tkrajacic June 9, 2023 13:23
Copy link
Sponsor

@tkrajacic tkrajacic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gwynne gwynne merged commit a88d025 into main Jun 9, 2023
19 checks passed
@gwynne gwynne deleted the revert-PSQLError-bandaid branch June 9, 2023 13:32
@VaporBot
Copy link

VaporBot commented Jun 9, 2023

These changes are now available in 2.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants