Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanups #40

Merged
merged 6 commits into from
May 30, 2023
Merged

Misc cleanups #40

merged 6 commits into from
May 30, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented May 27, 2023 •
edited

  • Updates min Swift version to 5.6 to match Vapor
  • Updates CI (it's a Gwynne PR, what were you expecting?)
  • Updates README

@gwynne gwynne requested a review from 0xTim May 27, 2023 16:32
@gwynne gwynne added the semver-minor Contains new APIs label May 27, 2023
MahdiBM
MahdiBM approved these changes May 27, 2023
View reviewed changes
Copy link

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is going to surprise you, but LGTM!

MahdiBM
MahdiBM reviewed May 27, 2023
View reviewed changes
README.md Show resolved Hide resolved
This was referenced May 27, 2023
Merged
Merged
@gwynne gwynne merged commit 09fac77 into main May 30, 2023
11 checks passed
@gwynne gwynne deleted the gwynne-patch-1 branch May 30, 2023 01:38
@VaporBot
Copy link

These changes are now available in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MahdiBM MahdiBM MahdiBM approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gwynne @VaporBot @0xTim @MahdiBM